Make "see issue" consistent#63008
Closed
eupn wants to merge 3 commits intorust-lang:masterfrom
eupn:consistent-see-issue
Closed
Make "see issue" consistent#63008eupn wants to merge 3 commits intorust-lang:masterfrom eupn:consistent-see-issue
eupn wants to merge 3 commits intorust-lang:masterfrom
eupn:consistent-see-issue
Conversation
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
jonas-schievink
added
the
S-waiting-on-review
ghost
suggested changes
Jul 28, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
there are some more inconsistencies that should be fixed (at least some of them):
See issue #49146 <https://github.com/rust-lang/rust/issues/49146> \
for more information.", kind),
for more information, see issue \
#57563 <https://github.com/rust-lang/rust/issues/57563>");
see issue #43162 <https://github.com/rust-lang/rust/issues/43162#issuecomment-320764675>"
please see issue #44136 <https://github.com/rust-lang/rust/issues/44136>
for more context, see issue #60210 <https://github.com/rust-lang/rust/issues/60210>
see issue #46062 <https://github.com/rust-lang/rust/issues/46062> for more details
I think, the order should be consistent, as well as the inclusion of "for more information/details"
Contributor
Author
I should've made this consistent as well. In this PR, I was only concerned about the consistency of Github links to the issues. |
ghost
approved these changes
Jul 28, 2019
Member
|
r? @varkor |
Contributor
|
I'll review this soon. However, I feel slightly uncomfortable, because @punitkoura had asked to take this issue. It would be a shame to waste this effort, though. If @punitkoura is happy with it, perhaps we could go with this pull request, but @punitkoura can be added as a co-author for doing the initial work? Then I can direct @punitkoura to another easy starter issue. |
Collaborator
|
☔ The latest upstream changes (presumably #63094) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Hi @varkor, these changes look good to me. I was also working on the same, but then saw this PR and therefore didn't raise another PR. It'd be really nice if I could be added as a co-author though :) |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
|
It'd be nice to normalise the following strings that appear:
I personally prefer "see [...] for more information", as it has the link early on. Apart from that, this looks good. If you could squash the |
varkor
reviewed
Jul 29, 2019
Contributor
Author
@punitkoura don't you mind if I'll use your email |
Collaborator
|
☔ The latest upstream changes (presumably #63124) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
@eupn, yes, that email id works |
Collaborator
|
☔ The latest upstream changes (presumably #63148) made this pull request unmergeable. Please resolve the merge conflicts. |
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Contributor
Author
Contributor
|
Thanks! @bors r+ |
Collaborator
|
📌 Commit 7336626 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Jul 31, 2019
Make "see issue" consistent Fixes rust-lang#62976. h/t to @punitkoura for initial patterns search. r? @varkor
bors
added
S-waiting-on-author
Contributor
Author
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 2ae06197c97b63466f7854421b8f9f61dd9fb2d2 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #63180) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Collaborator
|
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message |
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-authored-by: eupn <eupn@protonmail.com> Co-authored-by: Punit Singh Koura <pkoura@andrew.cmu.edu>
Co-Authored-By: varkor <github@varkor.com>
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Member
|
@bors p=1 since this is pretty conflict-prone |
Contributor
|
@eupn: there have been more merge conflicts, so you'll need to rebase and force push again. |
Collaborator
|
☔ The latest upstream changes (presumably #63627) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Ping from triage. @eupn any updates on this? Thanks. |
Contributor
Author
|
I’ll rebase it soon! |
Member
|
Ping from triage: @eupn any updates on this? |
1 similar comment
Member
|
Ping from triage: @eupn any updates on this? |
|
Ping from Triage: closing due to inactivity. Thanks for the PR @eupn! If you do rebase and have updates, please re-open. |
joelpalmer
added
S-inactive
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Feb 8, 2020
…, r=Dylan-DPC Make issue references consistent Fixes rust-lang#62976 cc rust-lang#63008 r? @varkor because you reviewed the original pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #62976. h/t to @punitkoura for initial patterns search.
r? @varkor